Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the owns relation #392

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat: Add the owns relation #392

merged 2 commits into from
Apr 30, 2024

Conversation

mwcampbell
Copy link
Contributor

This is a standard ARIA relation, so I'm surprised we didn't already inherit it from Chromium; I doubt I would have deliberately left it out or removed it. Anyway, I noticed it while going through the relations in GTK.

@DataTriny
Copy link
Member

Is it a good idea to add it without mentioning right away that the children property is preferred? As a non-native English speaker it isn't obvious to me that the owns property actually stores direct descendants.

@mwcampbell
Copy link
Contributor Author

Good point. Hopefully the documentation I just added is clear enough.

@DataTriny
Copy link
Member

It is. Thanks!

@DataTriny DataTriny merged commit fd668dd into main Apr 30, 2024
10 checks passed
@DataTriny DataTriny deleted the add-owns branch April 30, 2024 12:46
@mwcampbell mwcampbell mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants