Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose the class name property #385

Merged
merged 1 commit into from
Apr 29, 2024
Merged

feat: Expose the class name property #385

merged 1 commit into from
Apr 29, 2024

Conversation

mwcampbell
Copy link
Contributor

As far as I know, only UIA on Windows has such a property. But this simple feature is helping me debug my GTK AccessKit integration, since it makes it easy to find the GTK class of any accessible object, e.g. via NVDA+F1.

@DataTriny
Copy link
Member

DataTriny commented Apr 24, 2024

I can easily see how this can be useful when debugging. Apart from this very specific usecase reasons why ATs would need that aren't very appealing to me. I'm pretty sure NVDA relies on it to patch some broken widget implementations, but I don't think AccessKit should encourage this way of dealing with issues. I think this information is too deep in UI toolkits internals to be exposed. Furthermore with other programming languages UI toolkit developers will have to resort to expensive type reflection to provide this.
My opinion would be to entirely drop the property from our schema.

@mwcampbell
Copy link
Contributor Author

We always have to be pragmatic about things like this. The goal is as much accessibility as possible, by any means necessary. That includes workarounds implemented by the screen reader. If a screen reader workaround based on a widget's class name could help a blind person get or keep a job, then it's worth it. Of course, it won't be practical for all toolkits to expose this property, but we should make the option available.

@mwcampbell
Copy link
Contributor Author

Another argument for exposing the class name: For toolkits that can do it in a generic, low-overhead way, as GTK can, it gives Windows screen reader users, and maybe Linux screen reader users in the future if the Newton project is successful, an easy way to add more information to their accessibility bug reports.

@DataTriny
Copy link
Member

I think the bug report use case would be better served by having a good implementation of the Debug trait for Node, something I'm interested in tackling.

But I don't want to block this any longer. Implementors who can easily provide this are free to do so, even if I still think it is not a good idea.

@DataTriny DataTriny merged commit 53dcf2a into main Apr 29, 2024
10 checks passed
@DataTriny DataTriny deleted the class-name branch April 29, 2024 10:47
@mwcampbell mwcampbell mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants