Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mbedtls 2.28: Fix compilation on MS-DOS DJGPP #9811

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

SuperIlu
Copy link
Contributor

@SuperIlu SuperIlu commented Dec 1, 2024

Description

mbedTLS does not compile on MS-DOS DJGPP because the toolchain does define __unix__, but does not provide suseconds_t.
Excluding the code path with modifying the #if to be false when __DJGPP__ is defined makes it compile fine.

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Sorry, something went wrong.

Signed-off-by: SuperIlu <superilu@yahoo.com>
Signed-off-by: SuperIlu <superilu@yahoo.com>
@gilles-peskine-arm gilles-peskine-arm added enhancement needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Dec 2, 2024
Signed-off-by: SuperIlu <superilu@yahoo.com>
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faithful backport of the original.

@yanesca yanesca added this pull request to the merge queue Dec 3, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 7198389 Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-platform Portability layer and build scripts enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants