Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.28] Drop armcc5 support in all.sh #9736

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[2.28] Drop armcc5 support in all.sh #9736

merged 1 commit into from
Oct 30, 2024
+5 −24

Conversation

mpg
Copy link
Contributor

@mpg mpg commented Oct 29, 2024 •
edited by paul-elliott-arm
Loading

Description

It is my understanding that with the migration to a new license scheme in the CI, we are loosing support for armcc5. Since this is a legacy version, we can just stop testing with it.

PR checklist

Sorry, something went wrong.

@mpg mpg added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work labels Oct 29, 2024
@mpg mpg self-assigned this Oct 29, 2024
@mpg mpg changed the base branch from development to mbedtls-2.28 October 29, 2024 10:29
@gilles-peskine-arm gilles-peskine-arm self-requested a review October 29, 2024 10:41
@mpg mpg changed the title Drop armcc5 2.28 [2.28] Drop armcc5 support in all.sh Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
@mpg
Drop building with armcc5 in all.sh
Loading
Loading status checks…
a674e98 
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
@mpg mpg force-pushed the drop-armcc5-2.28 branch from 4a85c2c to a674e98 Compare October 29, 2024 10:53
gilles-peskine-arm
gilles-peskine-arm approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've checked locally that ARMC5_BIN_DIR=/none ARMC6_BIN_DIR=~/Packages/ARMCompiler6.6/bin ./tests/scripts/all.sh build_armcc is doing the expected builds.

scripts/output_env.sh
@@ -78,10 +78,6 @@ print_version "cmake" "--version" "" "head -n 1"
echo

if [ "${RUN_ARMCC:-1}" -ne 0 ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor: it still says “armcc” in a comment near the top of the file.

@gilles-peskine-arm gilles-peskine-arm added component-test Test framework and CI scripts size-xs Estimated task size: extra small (a few hours at most) labels Oct 29, 2024
paul-elliott-arm
paul-elliott-arm approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@paul-elliott-arm paul-elliott-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paul-elliott-arm paul-elliott-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Oct 30, 2024
@paul-elliott-arm paul-elliott-arm added this pull request to the merge queue Oct 30, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 89c68e2 Oct 30, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm

@paul-elliott-arm paul-elliott-arm

Assignees

@mpg mpg

Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts priority-very-high Highest priority - prioritise this over other review work size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpg @gilles-peskine-arm @paul-elliott-arm