Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.28] tests/ssl_helpers: Check that message queue is popped #9440

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[Backport 2.28] tests/ssl_helpers: Check that message queue is popped #9440

merged 1 commit into from
Aug 1, 2024
+4 −1

Conversation

sezrab
Copy link
Contributor

@sezrab sezrab commented Jul 31, 2024

Trivial backport of #8775

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Sorry, something went wrong.

@tgonzalezorlandoarm @sezrab
tests/ssl_helpers: Check that message queue is popped

Verified

This commit was signed with the committer’s verified signature.
vszakats Viktor Szakats
GPG key ID: B5ABD165E2AEF201
Verified
Learn about vigilant mode
Loading
Loading status checks…
a526528 
mbedtls_test_mock_tcp_recv_msg is currently popping a message
queue and does not check if this was done correctly.

This extra check makes the test more complete/robust.

Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
@sezrab sezrab added needs-review Every commit must be reviewed by at least two team members, component-test Test framework and CI scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most) labels Jul 31, 2024
gilles-peskine-arm
gilles-peskine-arm approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eleuzi01
eleuzi01 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eleuzi01 eleuzi01 mentioned this pull request Aug 1, 2024
Merged
4 tasks
@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Aug 1, 2024
@eleuzi01 eleuzi01 mentioned this pull request Aug 1, 2024
Merged
4 tasks
@bensze01 bensze01 added this pull request to the merge queue Aug 1, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 6c3ad6a Aug 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm

@eleuzi01 eleuzi01

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-test Test framework and CI scripts priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)
Projects
Non-roadmap pull requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sezrab @gilles-peskine-arm @eleuzi01 @bensze01 @tgonzalezorlandoarm