Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Explicitly report bad connection in error messaging for getUpdateSql() / getInsertSql() / rs2html. #993

Open
1 task
NathanGibbs3 opened this issue Jun 28, 2023 · 0 comments
Labels
triage New issues not yet reviewed by ADOdb developers

Comments

@NathanGibbs3
Copy link
Contributor

NathanGibbs3 commented Jun 28, 2023

Description

Noticed while working on #899 . The Error message states Connection or SQL invalid. It's ambiguous what the actual issue is. With some additional code we could separate the connection issue from the invalid SQL issue and return a more meaningful error message.

Environment

  • ADOdb version: < 5.22.7
  • Driver or Module: All
  • Database type and version: All
  • PHP version: All
  • Platform: All
  • I have tested that the problem is reproducible in the latest release / master branch / hotfix branch

Steps to reproduce

Detailed, step-by-step instructions to reproduce the behavior, including:

  • code snippet
  • SQL to create and populate database objects used by the code snippet
CREATE TABLE test ( test VARCHAR(255) );

Expected behavior

An explicit error message when the DB is not connected.

Additional context

See comment thread on #899
Depends on a fix for #994

@NathanGibbs3 NathanGibbs3 added the triage New issues not yet reviewed by ADOdb developers label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage New issues not yet reviewed by ADOdb developers
Projects
None yet
Development

No branches or pull requests

1 participant