ADOConnection::Execute return type too revealing

[Itatsi]

Description

The return type of the ADOConnection::Execute method is defined as folloing:

ADOdb/adodb.inc.php

Line 1521 in 928936a

* @return ADORecordSet|bool

but the docu says: "If the execution succeeds, it returns a recordset. [...] if the execution fails, it returns false."

In the code I could not find a place which returns true. Is there any particular reason why it can return, as defined by phpdoc, bool and not only false?

Environment

• ADOdb version: master

Expected behavior

`* @return ADORecordSet|false

`### Additional context
the reason I ask is because I usually treat the result as follows:

$res = $db->execute($selectSql);
if ($res && $res->RecordCount() >= 1) {

Here, however, a code analysis by psalm rightly criticizes that it could also return true according to phpdoc.

[dregad]

No reason, just an inconsistency. Thanks for pointing it out.