Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated dynamic property assignments #954

Closed
1 task done
SUXUMI opened this issue Apr 14, 2023 · 1 comment
Closed
1 task done

Deprecated dynamic property assignments #954

SUXUMI opened this issue Apr 14, 2023 · 1 comment
Assignees
@dregad
Labels
bug PHP8.2 PHP8.2 Compatibility Issues
Milestone
v5.22.6

Comments

@SUXUMI
Copy link

SUXUMI commented Apr 14, 2023

Description

Please fix deprecated dynamic property assignments:
$_maxRecordCount in /adodb-lib.inc.php:532
$rowsPerPage in /adodb-lib.inc.php:559

Environment

  • ADOdb version: 5.22.5
  • Driver or Module: MySQL
  • Database type and version: MariaDB
  • PHP version: 8.2.5
  • Platform: Unix
  • I have tested that the problem is reproducible in the latest release / master branch / hotfix branch

Steps to reproduce

Detailed, step-by-step instructions to reproduce the behavior, including:

  • initiate DB connection
@SUXUMI SUXUMI added the triage New issues not yet reviewed by ADOdb developers label Apr 14, 2023
@dregad dregad self-assigned this Apr 15, 2023
@dregad dregad added bug PHP8.2 PHP8.2 Compatibility Issues and removed triage New issues not yet reviewed by ADOdb developers labels Apr 15, 2023
@dregad dregad added this to the v5.22.6 milestone Apr 15, 2023
@dregad
Copy link
Member

dregad commented Apr 15, 2023

Thanks for the bug report

dregad added a commit that referenced this issue Apr 15, 2023
@dregad
Add missing AODRecordSet::$rowsPerPage declaration
35e2fea 
Fixes #954
@dregad dregad closed this as completed in 5651747 Apr 15, 2023
@dregad dregad mentioned this issue Apr 16, 2023
Closed
dregad added a commit that referenced this issue Apr 18, 2023
@dregad
Fix bad merge conflict resolution
760b1ca 
Merge commit 917c54e did not resolve
conflicted adodb.inc.php correctly: changes in the hotfix/5.22 branch
were simply ignored instead of being selectively applied.

As a result, the fix for #954 and some PHPDoc improvements were not
applied.

Fixes #960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dregad dregad

Labels
bug PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Milestone
v5.22.6
Development

No branches or pull requests
2 participants
@dregad @SUXUMI