Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete ADOConnection::$databaseName property #932

Closed
dregad opened this issue Mar 12, 2023 · 1 comment
Closed

Remove obsolete ADOConnection::$databaseName property #932

dregad opened this issue Mar 12, 2023 · 1 comment
Labels
code cleanup core ADOdb core (library and base classes) db2 IBM DB2 (Tier 1) mssql Non-native connection For SQL Server (Tier 1) mssqlnative Native driver for SQL Server driver (Tier 1) mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) pdo The PHP PDO Driver (Tier 2)
Milestone
v5.22.5

Comments

@dregad
Copy link
Member

dregad commented Mar 12, 2023

ADOConnection::databaseName was marked as obsolete in ADOdb 4.66.

Since the assignment that was kept for backwards-compatibility in the ADOConnection::selectDB() method is causing deprecation warnings in PHP 8.2 (see #904), now is the time to get rid of it.
@dregad dregad added code cleanup mssqlnative Native driver for SQL Server driver (Tier 1) mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) db2 IBM DB2 (Tier 1) pdo The PHP PDO Driver (Tier 2) core ADOdb core (library and base classes) mssql Non-native connection For SQL Server (Tier 1) labels Mar 12, 2023
@dregad dregad added this to the v5.22.5 milestone Mar 12, 2023
dregad added a commit that referenced this issue Mar 12, 2023
@dregad
Remove deprecated $databaseName property
e475b4c 
ADOConnection::$databaseName was marked as obsolete in ADOdb 4.66.

Since the assignment that was kept for backwards-compatibility in the
ADOConnection::selectDB() method is causing deprecation warnings with
PHP 8.2, now is the time to get rid of it.

The 2018 rewrite of DB2 driver introduced a private $databaseName
property; this has been removed in favor of ADOConnection::$database.

Fixes #932, #904

Signed-off-by: Damien Regad <dregad@mantisbt.org>
@dregad
Copy link
Member Author

dregad commented Mar 12, 2023

Fixed in e475b4c

@dregad dregad closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup core ADOdb core (library and base classes) db2 IBM DB2 (Tier 1) mssql Non-native connection For SQL Server (Tier 1) mssqlnative Native driver for SQL Server driver (Tier 1) mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) pdo The PHP PDO Driver (Tier 2)
Projects
None yet
Milestone
v5.22.5
Development

No branches or pull requests
1 participant
@dregad