Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dynamic properties for ADOFieldObject class #906

Closed
mnewnham opened this issue Nov 30, 2022 · 2 comments
Closed

Allow dynamic properties for ADOFieldObject class #906

mnewnham opened this issue Nov 30, 2022 · 2 comments
Labels
bug db2 IBM DB2 (Tier 1) firebird Firebird (Tier 2) mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) OCI8 (Oracle) Oracle DBMS (Tier 1) pgsql PostgreSQL (Tier 1) PHP8.2 PHP8.2 Compatibility Issues
Milestone
v5.22.5

Comments

@mnewnham
Copy link
Contributor

mnewnham commented Nov 30, 2022 •
edited by dregad

Dynamic attributes should not be assigned to the ADOfieldObject object of mysql_fetch_field() in ADORecordset::Fields()

Deprecated: Creation of dynamic property ADOFieldObject::$orgname is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$table is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$orgtable is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$def is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$db is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$catalog is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$length is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$charsetnr is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$flags is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$decimals is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$auto_increment is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$binary is deprecated in drivers/adodb-mysqli.inc.php on line 1487

Deprecated: Creation of dynamic property ADOFieldObject::$unsigned is deprecated in drivers/adodb-mysqli.inc.php on line 1487
@mnewnham mnewnham added bug mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) PHP8.2 PHP8.2 Compatibility Issues labels Nov 30, 2022
@dregad dregad added this to the v5.22.5 milestone Jan 19, 2023
@dregad dregad added pgsql PostgreSQL (Tier 1) OCI8 (Oracle) Oracle DBMS (Tier 1) db2 IBM DB2 (Tier 1) firebird Firebird (Tier 2) labels Mar 12, 2023
@dregad
Copy link
Member

dregad commented Mar 12, 2023

Due to the inherently dynamic nature of ADOFieldObject class, I currently do not see any alternative but to add the #[\AllowDynamicProperties] attribute.

I'll fix this one like that for now, if you have a better idea please let me know.

dregad added a commit that referenced this issue Mar 12, 2023
@dregad
Allow dynamic properties for ADOFieldObject class
d085fc8 
Fixes #906
@dregad
Copy link
Member

dregad commented Mar 12, 2023

Fixed in d085fc8

@dregad dregad closed this as completed Mar 12, 2023
@dregad dregad mentioned this issue Mar 12, 2023
Closed
dregad added a commit to dregad/ADOdb that referenced this issue Mar 14, 2023
@dregad
Allow dynamic properties for ADOFieldObject class
2c881b6 
Also define a couple of commonly used properties.

Fixes ADOdb#906

Signed-off-by: Damien Regad <dregad@mantisbt.org>
@dregad dregad changed the title [mysql] Dynamic attributes should not be assigned to the ADOfieldObject object of mysql_fetch_field() in ADORecordset::Fields() Allow dynamic properties for ADOFieldObject class Mar 17, 2023
dregad added a commit that referenced this issue Mar 17, 2023
@dregad
Define a few common properties in ADOFieldObject
92443a3 
Fixes #906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug db2 IBM DB2 (Tier 1) firebird Firebird (Tier 2) mysqli MySQL and compatible drivers (MariaDB, etc) (Tier 1) OCI8 (Oracle) Oracle DBMS (Tier 1) pgsql PostgreSQL (Tier 1) PHP8.2 PHP8.2 Compatibility Issues
Projects
None yet
Milestone
v5.22.5
Development

No branches or pull requests
2 participants
@dregad @mnewnham