Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAssoc: FetchMode ADODB_FETCH_DEFAULT should respect the result from the driver rather than putting values in a numeric array. #886

Closed
clarumedia opened this issue Sep 27, 2022 · 1 comment · Fixed by #900
Closed

GetAssoc: FetchMode ADODB_FETCH_DEFAULT should respect the result from the driver rather than putting values in a numeric array. #886

clarumedia opened this issue Sep 27, 2022 · 1 comment · Fixed by #900
Assignees
@mnewnham
Labels
bug core ADOdb core (library and base classes)
Milestone
v5.22.5

Comments

@clarumedia
Copy link

clarumedia commented Sep 27, 2022 •
edited

ADOdb/adodb.inc.php

Line 4313 in e3e3d14

if ($fetchMode == ADODB_FETCH_ASSOC

ADODB_FETCH_DEFAULT should be included as one of the options to ensure that the recordset is returned in the default provided by the PHP driver as per the documentation https://adodb.org/dokuwiki/doku.php?id=v5:reference:adodb_fetch_mode

if ($fetchMode == ADODB_FETCH_DEFAULT
|| $fetchMode == ADODB_FETCH_ASSOC
|| $fetchMode == ADODB_FETCH_BOTH)
{

Tested using mysqli
@mnewnham mnewnham added bug core ADOdb core (library and base classes) labels Oct 1, 2022
@mnewnham
Copy link
Contributor

mnewnham commented Oct 1, 2022

Well spotted, thanks

@clarumedia clarumedia mentioned this issue Oct 3, 2022
Open
@mnewnham mnewnham self-assigned this Nov 19, 2022
mnewnham added a commit that referenced this issue Nov 19, 2022
@mnewnham
ADODB_FETCH_DEFAULT should be treated as ASSOC, see #886
afb73d4
@mnewnham mnewnham linked a pull request Nov 19, 2022 that will close this issue
ADODB_FETCH_DEFAULT should be treated as ASSOC in getAssoc() method #900
Merged
@dregad dregad added this to the v5.22.5 milestone Nov 23, 2022
@dregad dregad closed this as completed in 35ea1f5 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnewnham mnewnham

Labels
bug core ADOdb core (library and base classes)
Projects
None yet
Milestone
v5.22.5
Development

Successfully merging a pull request may close this issue.

ADODB_FETCH_DEFAULT should be treated as ASSOC in getAssoc() method ADOdb/ADOdb
3 participants
@dregad @mnewnham @clarumedia