Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move caching to properties of ADORecordSet class #747

Open
dregad opened this issue Aug 14, 2021 · 0 comments
Open

Move caching to properties of ADORecordSet class #747

dregad opened this issue Aug 14, 2021 · 0 comments
Labels
enhancement OCI8 (Oracle) Oracle DBMS (Tier 1) pgsql PostgreSQL (Tier 1)
Milestone
v5.24.0

Comments

@dregad
Copy link
Member

dregad commented Aug 14, 2021

Follow-up on #687 (comment)

Adapt mssqlnative and oci8 drivers to store their cache in a property of the parent class.
@dregad dregad added enhancement pgsql PostgreSQL (Tier 1) OCI8 (Oracle) Oracle DBMS (Tier 1) labels Aug 14, 2021
@dregad dregad added this to the v5.22.0 milestone Aug 14, 2021
@dregad dregad mentioned this issue Aug 15, 2021
Closed
@mnewnham mnewnham mentioned this issue Sep 21, 2021
Open
mnewnham added a commit that referenced this issue Sep 22, 2021
@mnewnham
Moved the class variables to the parent see #747
207386d 
The properties to be used as basis for re-factor of pgsql fetchfieldarray #687
@dregad dregad modified the milestones: v5.22.0, v5.23.0 Oct 31, 2021
mnewnham added a commit that referenced this issue Dec 5, 2021
@mnewnham
standardize caching of properties of ADORecordSet class #747
0ef31ef 
The method of retrieval of the field properties of a recordset now has a standardized method, setFieldObjectsCache(), which is called immediately after initial recordset retrieval. The objects retrieved are stored in a parent level variable, fieldObjectsCache.  calls to fetchfield() now simply reads the cache instead of re-querying the database.

This methodology is usable for all drivers
dregad pushed a commit that referenced this issue Feb 6, 2022
@mnewnham @dregad
Standardize caching of properties of ADORecordSet class
7e9caa3 
The method of retrieval of the field properties of a recordset now has a
standardized method, setFieldObjectsCache(), which is called immediately
after initial recordset retrieval. The objects retrieved are stored in a
parent level variable, fieldObjectsCache.  calls to fetchfield() now
simply reads the cache instead of re-querying the database.

This methodology is usable for all drivers

Fixes #747
@dregad dregad modified the milestones: v5.23.0, 5.24.0 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement OCI8 (Oracle) Oracle DBMS (Tier 1) pgsql PostgreSQL (Tier 1)
Projects
None yet
Milestone
v5.24.0
Development

No branches or pull requests
1 participant
@dregad