Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SCRAM-SHA for encrypted sessions #1015

Open
Neustradamus opened this issue Dec 15, 2023 · 5 comments
Open

Use SCRAM-SHA for encrypted sessions #1015

Neustradamus opened this issue Dec 15, 2023 · 5 comments
Labels
feature Enhancement requests session Session Management

Comments

@Neustradamus
Copy link

Dear @ADOdb team,

Can you add supports of :

  • SCRAM-SHA-1
  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

You can add too:

  • SCRAM-SHA-224
  • SCRAM-SHA-224-PLUS
  • SCRAM-SHA-384
  • SCRAM-SHA-384-PLUS

A "big" list has been done in last link of this ticket.


SCRAM-SHA-1(-PLUS):

SCRAM-SHA-256(-PLUS):

SCRAM-SHA-512(-PLUS):

SCRAM-SHA3-512(-PLUS):

SCRAM BIS: Salted Challenge Response Authentication Mechanism (SCRAM) SASL and GSS-API Mechanisms:

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

JMAP:

2FA:

IANA:

Linked to:

@Neustradamus Neustradamus added the triage New issues not yet reviewed by ADOdb developers label Dec 15, 2023
@dregad
Copy link
Member

dregad commented Dec 15, 2023

@Neustradamus I'm sorry but I really don't know what this is all about, and what it has to do with ADOdb. Please clarify your expectations.

Also kindly note that ADOdb is community-maintained so if you wish some feature to be added, then we expect a contribution in the form of a pull request rather than al list of RFC's with no actual specification of how they should be applied to our library.

@Neustradamus
Copy link
Author

@dregad: The goal is to have salted password hashes to be more secure and to be compatible with other products/softwares in the World since 2011. It replaces old unsecure MD5...

@dregad
Copy link
Member

dregad commented Dec 15, 2023

That does not quite explain how this would apply to ADOdb... We are just an abstraction layer on top of various databases, and we don't store any passwords - we just pass them on to the underlying DB.

@Neustradamus
Copy link
Author

@dregad: The goal is to have a better security than unsecure "ADODB_Encrypt_MD5" and "ADODB_Encrypt_SHA1", etc.:

@dregad dregad added feature Enhancement requests session Session Management and removed triage New issues not yet reviewed by ADOdb developers labels Dec 18, 2023
@dregad
Copy link
Member

dregad commented Dec 18, 2023

OK I see what you mean now, it's related to sessions module.

As mentioned previously, feel free to submit a pull request with new encryption classes using your better algorithm to replace the legacy MD5 / SHA1.

@dregad dregad changed the title SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256-PLUS + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports Use SCRAM-SHA for encrypted sessions Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancement requests session Session Management
Projects
None yet
Development

No branches or pull requests

2 participants