Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to use cross-service sdk in pub-sub #43

Conversation

giangndm
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (7072dfc) 84.14% compared to head (9a740d7) 85.96%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   84.14%   85.96%   +1.81%     
==========================================
  Files         106      105       -1     
  Lines       11298    12130     +832     
==========================================
+ Hits         9507    10427     +920     
+ Misses       1791     1703      -88     
Files Coverage Δ
packages/core/identity/src/conn_id.rs 100.00% <100.00%> (+35.71%) ⬆️
packages/core/identity/src/node_id.rs 88.00% <100.00%> (+22.72%) ⬆️
packages/core/router/src/force_local.rs 100.00% <100.00%> (+100.00%) ⬆️
packages/core/router/src/force_node.rs 100.00% <100.00%> (+100.00%) ⬆️
packages/core/router/src/lib.rs 100.00% <100.00%> (+52.63%) ⬆️
packages/core/utils/src/hashmap.rs 78.07% <100.00%> (+16.42%) ⬆️
packages/core/utils/src/random.rs 100.00% <100.00%> (+100.00%) ⬆️
packages/core/utils/src/vec_dequeue.rs 91.34% <100.00%> (+50.96%) ⬆️
packages/network/src/behaviour.rs 38.88% <100.00%> (+1.38%) ⬆️
packages/network/src/plane/bus_impl.rs 90.29% <ø> (ø)
... and 15 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm marked this pull request as ready for review November 13, 2023 17:08
@giangndm giangndm merged commit dc2cc50 into 8xFF:master Nov 13, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant