Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing wrong release consumers. refactor some releated logs #39

Merged

Conversation

giangndm
Copy link
Contributor

@giangndm giangndm commented Nov 3, 2023

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6dd98f5) 82.81% compared to head (ed5e74f) 83.32%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   82.81%   83.32%   +0.50%     
==========================================
  Files         106      106              
  Lines       11137    11218      +81     
==========================================
+ Hits         9223     9347     +124     
+ Misses       1914     1871      -43     
Files Coverage Δ
...kages/services/pub_sub/src/relay/source_binding.rs 95.62% <100.00%> (+0.09%) ⬆️
packages/services/pub_sub/src/sdk/consumer.rs 98.78% <100.00%> (+13.32%) ⬆️
packages/services/pub_sub/src/sdk/consumer_raw.rs 76.92% <100.00%> (+76.92%) ⬆️
...ckages/services/pub_sub/src/sdk/consumer_single.rs 100.00% <100.00%> (ø)
packages/services/pub_sub/src/relay.rs 81.39% <50.00%> (-0.75%) ⬇️
packages/services/pub_sub/src/relay/local.rs 97.45% <0.00%> (ø)
packages/services/pub_sub/src/relay/logic.rs 94.00% <50.00%> (+0.42%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giangndm giangndm merged commit 09d5d9c into 8xFF:master Nov 3, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants