Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: primary entry point to the program isn't set correctly #1008

Merged
merged 1 commit into from Apr 5, 2024

Conversation

AlexandrChazov
Copy link
Contributor

@AlexandrChazov AlexandrChazov commented Apr 5, 2024

It's written in the package.json file that primary entry point has path "./dist/browser/index.js", but there is no such file there.

image

Although library works when I try to run integration tests with Jest for files which make import from node_module 'slickgrid' it complains Cannot find module 'slickgrid'

image

@ghiscoding ghiscoding merged commit 0714221 into 6pac:master Apr 5, 2024
2 checks passed
@ghiscoding
Copy link
Collaborator

ah yeah like I said I no longer use SlickGrid repo since I copied the same implementation into Slickgrid-Universal to be standalone, so yes you are correct we should link to the CJS version for Jest. The browser doesn't have to be linked since it's typically referenced as file directly (typically by CDN).

... so thanks, your assumption was correct.

@ghiscoding
Copy link
Collaborator

new release is out, cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants