Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use secrecy for OpenAIConfig and AzureConfig #114

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ironman5366
Copy link
Contributor

Addresses #113

println!("{:?}", config):

OpenAIConfig { api_base: "https://api.openai.com/v1", api_key: Secret([REDACTED alloc::string::String]), org_id: "" }

You have a great project here!

@64bit
Copy link
Owner

64bit commented Sep 26, 2023

Hi @ironman5366

Thank you for the PR, it needs a small change where we don't expose secrets without Secret<String> to clients. That way benefit of it propogates to all applications built using async-openai

Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

I'll bundle it in next release with other breaking changes, probably v0.15.0.

@64bit 64bit merged commit dbde022 into 64bit:main Sep 26, 2023
@TmLev
Copy link
Contributor

TmLev commented Oct 30, 2023

It would be nice to re-export secrecy::ExposeSecret trait so that downstream users don't have to add secrecy crate as a dependency just for that

@64bit
Copy link
Owner

64bit commented Nov 2, 2023

Dang! It doesn't work without adding dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants