Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not print key in Debug #112

Merged
merged 1 commit into from
Sep 24, 2023
Merged

do not print key in Debug #112

merged 1 commit into from
Sep 24, 2023

Conversation

Emilgardis
Copy link
Contributor

No description provided.

@64bit
Copy link
Owner

64bit commented Sep 24, 2023

Hi @Emilgardis Thank you for the PR!

Actually AzureConfig suffers from the same security issue. Might as well fix both in one go?

Verified

This commit was signed with the committer’s verified signature.
Emilgardis Emil Gardström
@Emilgardis
Copy link
Contributor Author

Done!

Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@64bit 64bit merged commit 3b04a6d into 64bit:main Sep 24, 2023
@64bit
Copy link
Owner

64bit commented Sep 24, 2023

This is released in v0.14.3

@TmLev
Copy link
Contributor

TmLev commented Sep 25, 2023

It also makes sense to use https://docs.rs/secrecy/latest/secrecy/

@Emilgardis Emilgardis deleted the dontprintkey branch September 25, 2023 09:38
@64bit
Copy link
Owner

64bit commented Sep 25, 2023

Thanks @TmLev thats actually a good suggestion.
I'm tracking it here #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants