Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add enum type for finish_reason #111

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Sep 24, 2023

The finish_reason is defined as an enum type in the OpenAI API spec: https://github.com/openai/openai-openapi/blob/master/openapi.yaml#L2821.

Signed-off-by: Akira Moroo <retrage01@gmail.com>
@64bit
Copy link
Owner

64bit commented Sep 24, 2023

Hi @retrage

Thank you for PR updating the type with spec.

Since this introduces breaking change, and its unknown to me how much spec has been updated - so I'll merge this PR when I get to sync code with full latest spec to avoid releasing multiple versions with breaking changes.

Please see #93

Copy link
Owner

@64bit 64bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR, its ready to be shipped!

@64bit 64bit merged commit 61bcb40 into 64bit:main Oct 30, 2023
@retrage retrage deleted the add-finish-reason-enum branch October 30, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants